Fix: on Intel x64, os.arch is either amd64 or x86_64 depending on the JVM. #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicGBauer
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the call-kmmbridge-publish job installs an x64 JDK on an arm64 Mac OS runner. I'm guessing that it's because KMMBridgeGithubWorkflow (which is deprecated by the way) uses actions/setup-java@v2, when current version of actions/setup-java is v4.
This led to the realization that some JVM use the identifier "x86_64" instead of "amd64" to identify what we call the x64 architecture.
This PR simply adds the "x86_64" identifier as an alias to "amd64" when detecting the system architecture.